Change in flashrom[master]: ichspi: Introduce HSFC_FCYCLE_MASK(n) macro

Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 ) Change subject: ichspi: Introduce HSFC_FCYCLE_MASK(n) macro ...................................................................... Patch Set 11: (1 comment) Patchset: PS6:
Also without this CL, the Flash Cycle bit field width is wrong for latest chipset. […] Yes it does answer. I could see the code has changed since PS6, but wanted to confirm, thanks!
-- To view, visit https://review.coreboot.org/c/flashrom/+/62891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id222304165610c7ae48e365d72ec8fdeea51c51d Gerrit-Change-Number: 62891 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Subrata Banik <subi.banik@gmail.com> Gerrit-Attention: Subrata Banik <subi.banik@gmail.com> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Mon, 02 May 2022 01:34:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik@google.com> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Anastasia Klimchuk (Code Review)