Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 )
Change subject: ft2232_spi: reintroduce generic GPIOL control ......................................................................
Patch Set 18:
(4 comments)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57810/comment/cb41a7a9_86eab32b PS17, Line 493: unsigned int pin = temp + 4;
Is this change intentional?
yes
https://review.coreboot.org/c/flashrom/+/57810/comment/a230bae3_cea0224a PS17, Line 503: pindir |= 1 << pin;
Is this change intentional?
yes
https://review.coreboot.org/c/flashrom/+/57810/comment/2adaae92_fafe3191 PS17, Line 524: int
Why not `uint8_t`?
Ack
https://review.coreboot.org/c/flashrom/+/57810/comment/45c7a3a7_68cd7386 PS17, Line 526: %i
Out of curiosity, why use `%i` here and `%d` in `snprintf()`?
Ah, that snprintf code was from Nico - aligned
-
Michael Niewöhner (Code Review)