Attention is currently required from: Alexander Goncharov, Anton Samsonov.
Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77089?usp=email )
Change subject: Remove dependency on C23 __has_include() ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Thanks for the patch! Can you please provide what compiler and version you used to test this patch? […]
In my understanding, this patch may be needed for all compilers based on legacy versions of EDG frontend, such as version 4.14, which is somewhat on par with GCC 5.5, for example. Those still happen to be used in embedded / certified systems.
Newer EDG versions like 5.1, which is somewhat on par with GCC 7.3, and of course the most recent versions like 6.4, which is somewhat on par with GCC 11.3, do not need this patch already. But those versions are not available on all target platforms.
Do you think such details should be present in commit message?
-
Anton Samsonov (Code Review)