Change in flashrom[staging]: Add option to read ROM layout from IFD - flashrom-gerrit

4 May 2017


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/17953 )
Change subject: Add option to read ROM layout from IFD
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/#/c/17953/13/ich_descriptors.c
File ich_descriptors.c:
PS13, Line 948: min(desc.content.NR + 1, ARRAY_SIZE(regions))
...
Um, no... `j` is used to index `layout->entries` and thus definitely
What I have is a Flash_Descriptor, a BIOS, and a GbE and no ME. content.NR == 2 so it won't get to GbE...
-- 
To view, visit https://review.coreboot.org/17953
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3
Gerrit-PatchSet: 13
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-HasComments: Yes