Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60841 )
Change subject: atavia: remove unused rget_io_perms() ......................................................................
atavia: remove unused rget_io_perms()
The atavia programmer does not use x86 IO Ports. Remove the dependency to it.
Change-Id: I1fa866b3b07adf5f7a51d58f53d6cad1f88d7210 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/60841 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile M atavia.c 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index 9a6d7b0..a914382 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,6 @@ DEPENDS_ON_X86_PORT_IO := \ CONFIG_ATAHPT \ CONFIG_ATAPROMISE \ - CONFIG_ATAVIA \ CONFIG_DRKAISER \ CONFIG_GFXNVIDIA \ CONFIG_INTERNAL \ diff --git a/atavia.c b/atavia.c index 8109768..e8bc945 100644 --- a/atavia.c +++ b/atavia.c @@ -20,7 +20,6 @@ #include <string.h> #include "flash.h" #include "programmer.h" -#include "hwaccess_x86_io.h" #include "platform/pci.h"
#define PCI_VENDOR_ID_VIA 0x1106 @@ -164,9 +163,6 @@ } free(arg);
- if (rget_io_perms()) - return 1; - dev = pcidev_init(ata_via, PCI_ROM_ADDRESS); /* Actually no BAR setup needed at all. */ if (!dev) return 1;