Change in flashrom[master]: libflashrom: Move documentation to header - flashrom-gerrit

2 May 2022


      Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63903 )
Change subject: libflashrom: Move documentation to header
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63903/comment/7af96a80_d32d3c96 
PS2, Line 16: 
            : Change-Id: I856b74d5bfea13722539be15496755a95e701eea
...
`Signed-of-by:` line required by upstream here.
Done
Patchset:
PS2:
...
Why you set this WIP? Do you plan any significant changes in this patch?
just making sure i did things right the first time!
Patchset:
PS4: 
Something in the rebase has made this not work any more. I am taking a look.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/63903
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I856b74d5bfea13722539be15496755a95e701eea
Gerrit-Change-Number: 63903
Gerrit-PatchSet: 4
Gerrit-Owner: Evan Benn evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Mon, 02 May 2022 04:05:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment