Attention is currently required from: Nico Huber, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54169 )
Change subject: programmer: Smoothen register_par_master API
......................................................................
Patch Set 3:
(1 comment)
File programmer.c:
https://review.coreboot.org/c/flashrom/+/54169/comment/964ac248_e82a444b
PS3, Line 100: if (data)
Just to clarify some ambiguity in my writing here. […]
Good thing there is one follow-up patch in my mind anyway: to move these lines / this line into register_master, I can address your suggestion there?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54169
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I95bc92f6c54c5bcdac1c522ca87054aaffed0f40
Gerrit-Change-Number: 54169
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 21 May 2021 01:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment