Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60272 )
Change subject: ichspi: Remove unneeded line breaks, add useful ones
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/60272/comment/eee6416f_28d713ca
PS4, Line 7: ichspi: Remove unneeded line breaks, add useful ones
There are also some other changes, e.g. added tabs.
https://review.coreboot.org/c/flashrom/+/60272/comment/51afc439_f241d26f
PS4, Line 13: 2) probe and read on Panther Point (7 series PCH)
Not this patch, actually. Also, a better test would be to check if the binary stays the same ;)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/60272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ca2902b7caaa95418b828b068c661afafdcd171
Gerrit-Change-Number: 60272
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 23 Dec 2021 12:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment