Change in flashrom[master]: tests: test write protection - flashrom-gerrit

11 May 2022


      Attention is currently required from: Nico Huber, Sergii Dmytruk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 )
Change subject: tests: test write protection
......................................................................
Patch Set 39: Code-Review+1
(2 comments)
Patchset:
PS39: 
Can you provide a description what each test is doing?
File tests/chip_wp.c:
https://review.coreboot.org/c/flashrom/+/59075/comment/196ccca9_d671fb97 
PS39, Line 63: static const struct flashchip chip_W25Q128_V = {
Why copying the chip?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59075
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8
Gerrit-Change-Number: 59075
Gerrit-PatchSet: 39
Gerrit-Owner: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Wed, 11 May 2022 14:52:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment