Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70349 )
Change subject: tree/: Change chip restore data type from uint8_t to void ptr
......................................................................
Patch Set 8:
(2 comments)
File s25f.c:
https://review.coreboot.org/c/flashrom/+/70349/comment/4f9bc2c1_b11336a1
PS5, Line 295: if (!data)
: return 1;
Second potential place for "out of memory" message.
Nik?
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/70349/comment/25f23823_3e6b62d9
PS5, Line 313: if (!data)
: return 1;
Should this print "out of memory" message before returning?
ditto
--
To view, visit
https://review.coreboot.org/c/flashrom/+/70349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I311b468a4b0349f4da9584c12b36af6ec2394527
Gerrit-Change-Number: 70349
Gerrit-PatchSet: 8
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Wed, 18 Jan 2023 00:11:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment