Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Light.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 )
Change subject: pony_spi.c: Fix memory leak in function pony_init_spi
......................................................................
Patch Set 10: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62724/comment/a289bf14_6a353de9
PS10, Line 9: I found the issue
nit (not blocking): The issue was found
https://review.coreboot.org/c/flashrom/+/62724/comment/5f1c8bfe_0e80b7c3
PS10, Line 11: changes
change,
https://review.coreboot.org/c/flashrom/+/62724/comment/641deae7_5c34bd91
PS10, Line 12: was no longer appeared
no longer appeared
Patchset:
PS10:
Looks good to me so far :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301
Gerrit-Change-Number: 62724
Gerrit-PatchSet: 10
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 08:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment