Attention is currently required from: Aarya, Anastasia Klimchuk.
DigitalDJ has posted comments on this change by DigitalDJ. ( https://review.coreboot.org/c/flashrom/+/84234?usp=email )
Change subject: erasure_layout: Fix init_eraseblock segmentation fault ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/84234/comment/3266f689_7f59b533?usp... : PS3, Line 9: Fix a segmentation fault that is caused by accessing an invalid "subedata" pointer on the last iteration of the init_eraseblock loop. Instead, short circuit the loop condition to check the sub block index first, and do not access the invalid pointer if it is the last sub block.
Could you please wrap commit message to 72 chars, as in our dev guide, thanks! […]
Done
https://review.coreboot.org/c/flashrom/+/84234/comment/7959c895_cf62b4ac?usp... : PS3, Line 10:
The one thing I want to ask you: […]
Done