[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU512C/XM25QU512D - flashrom-gerrit

14 Jul 2024


      Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83243?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU512C/XM25QU512D
......................................................................
Patch Set 4:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83243/comment/70f440b4_016647ac?usp... :
PS2, Line 22490: 64*1024
...
Please add spaces around `*`
Done
https://review.coreboot.org/c/flashrom/+/83243/comment/156c1aef_acda62ae?usp... :
PS2, Line 22506: .eraseblocks = { {4 * 1024, 16384} },
...
Please intend this line like the others
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/83243?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I251c66b5d3b4fc94242c2c9d6b7c0f03c1bd7d0b
Gerrit-Change-Number: 83243
Gerrit-PatchSet: 4
Gerrit-Owner: Ssunk ssunkkan@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Sun, 14 Jul 2024 04:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org