Attention is currently required from: Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58865 )
Change subject: hwaccess.c: move function declarations from programmer.h to hwaccess.h
......................................................................
Patch Set 2:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/58865/comment/ea2f6ee4_6f228350
PS2, Line 37: #include "programmer.h"
This was never needed since ich_descriptors.h also include programmer.h […]
Ah, right. Then it's just fine to have it here. We don't want to rely on
an indirect include.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I075fd86211c766ae3d5f29c76adbd7c5b9bdbd80
Gerrit-Change-Number: 58865
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 03 Nov 2021 18:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment