Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83243?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU512C/XM25QU512D ......................................................................
Patch Set 2:
(3 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83243/comment/94f8098a_f5eb9657?usp... : PS2, Line 22490: 64*1024 Please add spaces around `*`
https://review.coreboot.org/c/flashrom/+/83243/comment/5fe68caa_61734b15?usp... : PS2, Line 22495: FEATURE_4BA_ENTER_WREN Does enter/exit 4-byte mode depend on WREN? Or can it be done without WREN? I did not find in datasheet that it depends on WREN, maybe I missed?
There is another feature bit `FEATURE_4BA_ENTER`, without WREN.
https://review.coreboot.org/c/flashrom/+/83243/comment/fbeba744_482a8f4f?usp... : PS2, Line 22506: .eraseblocks = { {4 * 1024, 16384} }, Please intend this line like the others