Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
The patch is merge-ready :)
I just looked, there are unresolved comments.
Especially one of them on the topic of "getting the path from a pkgconfig variable" , it does look like waiting for reply and/or action? am I right or not?
The second one about vertical list is less important.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1
Gerrit-Change-Number: 68247
Gerrit-PatchSet: 7
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Mon, 31 Oct 2022 05:33:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment