Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49269 )
Change subject: bitbang_spi: Refactor `set_sck_set_mosi`
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49269/comment/f3c013ad_cf433f81
PS1, Line 11: for those that do not, because MOSI now has more time to stabilize.
In case of `.half_period = 0`, this would also mean that we
program the next MOSI value as the very next step after the
rising SCK edge. Tests would have to show if MOSI is then still
stable long enough.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49269
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia84d32965e56ca563062893ebbefbbea5c35814c
Gerrit-Change-Number: 49269
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-CC: Xiang W
wxjstz@126.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 26 Jun 2021 12:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment