Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept ......................................................................
Patch Set 12:
(6 comments)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/dc5d450c_66ac1847 PS7, Line 36: * functions. `platform_get_io_perms()` is called to get
There are two more in the lines above.
Done
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/d99cd62a_9200a127 PS11, Line 48: define USE_LIBC_LAST 1 : #define USE_LIBC_FIRST 2
Without the target/destination part, this is far from selfexplanatory.
Done
https://review.coreboot.org/c/flashrom/+/61276/comment/e43be743_c5f711b4 PS11, Line 58: USEIOPERM
Missing underscore.
Done
https://review.coreboot.org/c/flashrom/+/61276/comment/64a59422_d862308e PS11, Line 123: 1
Leftover?
Done
https://review.coreboot.org/c/flashrom/+/61276/comment/5aa9c5b2_f0725354 PS11, Line 146:
Maybe to catch some typos: […]
Done
https://review.coreboot.org/c/flashrom/+/61276/comment/5ece7aa1_e0abe9b9 PS11, Line 322:
Missing line break.
Done
-
Thomas Heijligen (Code Review)