Attention is currently required from: Name of user not set #1005084, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77581?usp=email )
Change subject: flashchips: Add support for MXIC MX25U25643G ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: xianzheng, I wanted to check, is this patch a new version of CB:76853 ? Is this ready for review?
For the future, in a case like this, you need to push a new patchset to existing patch (instead of creating a new patch). This means locally you do git commit --amend and then you check that Change-Id stays the same in the commit message. Change-Id is the way Gerrit knows the change belongs to the same patch.
For this patch you can leave as is, for future keep an eye on Change-Id and create new patchsets *for the same patch*. We also have info about working with git and gerrit in dev guides: https://www.flashrom.org/dev_guide/development_guide.html
thank you for contributing!
-
Anastasia Klimchuk (Code Review)