David Hendricks has posted comments on this change. ( https://review.coreboot.org/19031 )
Change subject: ich_descriptors: Fix range checks for dumps ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Looks like parts of the code need to be updated, but it looks like you're already doing that in some follow-up patches so feel free to ignore the comments.
https://review.coreboot.org/#/c/19031/4/ich_descriptors.c File ich_descriptors.c:
PS4, Line 739: desc->component.FLPB = dump[(getFCBA(&desc->content) >> 2) + 2]; Side note: This field seems to be absent in many of the most recent PCHes, so that might confuse the length check for code intended for newer platforms.
Line 748: desc->region.FLREGs[4] = dump[(getFRBA(&desc->content) >> 2) + 4]; A couple more FLREGs have been added in recent PCHes.
Line 755: desc->master.FLMSTR3 = dump[(getFMBA(&desc->content) >> 2) + 2]; Same as above - More have been added.