Attention is currently required from: Anastasia Klimchuk, Brian Norris, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email )
Change subject: udelay: only use OS time for delays, except on DOS ......................................................................
Patch Set 5:
(3 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/81545/comment/18111898_4f216adf : PS4, Line 121: DHAVE_NANOSLEEP=1
yeah, maybe something similar to the `Makefile.d/clock_gettime_test. […]
On reflection, this isn't even required. We previously only avoided using `nanosleep` on DOS, and DOS now has its own version of this file so we can assume this function is always available. Removed this check and the sleep+usleep branch in `internal_sleep`.
File udelay.c:
https://review.coreboot.org/c/flashrom/+/81545/comment/988fc1ba_e62af74f : PS4, Line 6: *
I think this counts as a significant change, maybe you want to add your copyright here?
Done
https://review.coreboot.org/c/flashrom/+/81545/comment/0ab1fadd_9bdfed46 : PS4, Line 76: timeusec
I'm gonna say you probably didn't test this part 😜
😬 thanks. I've added a test for basic delay operation and hacked meson.build temporarily to verify that everything builds and the test passes in both cases now.
-
Peter Marheine (Code Review)