Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56103 )
Change subject: spi_master: Use new API to register shutdown function ......................................................................
Patch Set 6: Code-Review+2
(3 comments)
Patchset:
PS6: This also fixes a lot resource leakage in case register_shutdown() would fail. That's worth to mention in the commit message!
Maybe we can also test it? I haven't looked closely if any of the affected programmer drivers are hooked up for lifecycle testing. If they are, hardcoding register_shutdown() to fail should result in less leakage after this change.
File ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/56103/comment/d827b913_fb1204bd PS6, Line 511: return 0; Just raising an eyebrow: this changes unrelated behaviour. Maybe worth to mention in the commit message: Fixes propagation of register_spi_master() return values.
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/56103/comment/8f15da3c_1009ae7d PS6, Line 1276: /* shutdown function does cleanup */ Still somewhat true, but less obvious what is meant.
-
Nico Huber (Code Review)