Change in flashrom[master]: Makefile: Make pkg-config mandatory to find libpci - flashrom-gerrit

21 Dec 2021


      Attention is currently required from: Thomas Heijligen.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59050 )
Change subject: Makefile: Make pkg-config mandatory to find libpci
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/59050/comment/7e673cd1_494e8e3e 
PS7, Line 772: # This is a dirty hack, but it saves us from checking all PCI drivers and all platforms manually.
             : # libpci may need raw memory, MSR or PCI port I/O on some platforms.
             : # Individual drivers might have the same needs as well.
...
We should split pci programmers to DEPENDS_ON_IO_PORTS, DEPENDS_ON_RAW_MEM_ACCESS, DEPENDS_ON_X86_MS […]
Yes, eventually, but for now I would just keep the comment above
`USE_RAW_ACCESS := yes`.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I21b4a261b34b7e688635fc6e20b7beebfa64c7ed
Gerrit-Change-Number: 59050
Gerrit-PatchSet: 13
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment