Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function - flashrom-gerrit

21 Jan 2021


      Attention is currently required from: Edward O'Callaghan, Angel Pons.
Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 )
Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49785/comment/fa73e26f_b8a3c655 
PS1, Line 9: used as write protection disable/enable
...
is it always used to toggle write-protect, or is it board-specific?
I believe it is board specific GPIO 88 could be connected to other pin.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/49785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1
Gerrit-Change-Number: 49785
Gerrit-PatchSet: 2
Gerrit-Owner: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 03:53:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment