Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52661 )
Change subject: jlink_spi.c: Drop jaylink_ prefix for spi data struct members
......................................................................
Patch Set 1: Verified+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52661/comment/4d129554_cbe953e3
PS1, Line 15: TEST=builds
Should result in the same binaries.
File jlink_spi.c:
https://review.coreboot.org/c/flashrom/+/52661/comment/0ca48cf3_2551c3b4
PS1, Line 486: if (jlink_data)
Unrelated: We have decided to trust `free(NULL)` to do the right (no)thing.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If6e68e0dabb6bfad1088ff975445961294bbc03d
Gerrit-Change-Number: 52661
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 27 Apr 2021 09:49:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment