Attention is currently required from: cattusqq@gmail.com.
Anastasia Klimchuk has posted comments on this change by cattusqq@gmail.com. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email )
Change subject: Add Glasgow to supported serprog programmers documentation ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1: Cattus, thank you for the contribution, and nice to meet you.
I read your post, I like it so much, very detailed information, it's just great!
- I held my breath when I read that the chip was not recognised... But then I kept reading and there was a happy ending at the end :)
- Somewhere in the middle there was a link on how to "write a mapping for flashrom", just wanted to say we also have a doc on this https://flashrom.org/contrib_howtos/how_to_add_new_chip.html. We did split a giant flashchips.c into a per-vendor file recently.
- If you want you can try to enable write-protection capability for the chip: because you have the datasheet and the actual chip. There is a section about it in the doc: https://flashrom.org/contrib_howtos/how_to_add_new_chip.html#write-protectio.... For the examples, look for the chip definitions that have test status TEST_OK_PREWB
Commit Message:
https://review.coreboot.org/c/flashrom/+/85527/comment/1e9bc633_fd397b83?usp... : PS1, Line 10: the project wouldnt compile with meson for me (MacOS 15.1) I first thought that flashrom does not compile, but then I read your blog post and now I think maybe that's the documentation did not compile?
I downloaded your patch and built with documentation, and so I added two comments (as you see below).
https://review.coreboot.org/c/flashrom/+/85527/comment/18e71279_d6bdcb84?usp... : PS1, Line 9: Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. : Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) : but tried to make it as similar as possible to what was already there. We wrap commit message by 72 chars, and I think the first line is longer (maybe the second one too)
https://flashrom.org/dev_guide/development_guide.html#commit-message-1
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/85527/comment/80bf589f_616b08ef?usp... : PS1, Line 105: Source for the Glasgow Project can be found `here https://github.com/GlasgowEmbedded/glasgow`_ This gives a warning `WARNING: Duplicate explicit target name: "here".`
So maybe you can change slightly, for example Here is the <source for the Glasgow Project> (in <> brackets would be the link text)
https://review.coreboot.org/c/flashrom/+/85527/comment/edef2f8e_6a300892?usp... : PS1, Line 108: 76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw What is this hash? :) I assume that's by mistake?