Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/59278 )
Change subject: programmer.h: Make pacc global state static local ......................................................................
programmer.h: Make pacc global state static local
TODO: Fix chipset_enable.c ??
Change-Id: I3bea1b93a7ca81dd42a64eec1e49a10f1fbda850 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M pcidev.c M programmer.h 2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/59278/1
diff --git a/pcidev.c b/pcidev.c index e57b90c..ddd13e9 100644 --- a/pcidev.c +++ b/pcidev.c @@ -21,7 +21,7 @@ #include "programmer.h" #include "hwaccess.h"
-struct pci_access *pacc; +static struct pci_access *pacc;
enum pci_bartype { TYPE_MEMBAR, diff --git a/programmer.h b/programmer.h index 41dc240..80bf3b7 100644 --- a/programmer.h +++ b/programmer.h @@ -119,8 +119,6 @@ struct pci_filter;
/* pcidev.c */ -// FIXME: This needs to be local, not global(?) -extern struct pci_access *pacc; int pci_init_common(void); uintptr_t pcidev_readbar(struct pci_dev *dev, int bar); struct pci_dev *pcidev_init(const struct dev_entry *devs, int bar);