Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function - flashrom-gerrit

3 Feb 2021


      Attention is currently required from: Shiyu Sun, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 )
Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49785/comment/064e8abb_9a5fe7a8 
PS2, Line 9: Gpio 88 toggle is used as write protection disable/enable now
           : and we need that to happen at the initialization of programmer.
Happy to +2 this however I still would like to see a better explanation as to why.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/49785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1
Gerrit-Change-Number: 49785
Gerrit-PatchSet: 2
Gerrit-Owner: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Shiyu Sun sshiyu@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 02:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment