Attention is currently required from: Alexander Goncharov, Thomas Heijligen, Victor Lim.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/82197?usp=email )
Change subject: doc: Add doc for supported flash chips ......................................................................
Patch Set 3:
(3 comments)
File doc/supported_hw/supported_flashchips.rst:
https://review.coreboot.org/c/flashrom/+/82197/comment/df9bde28_7255d088?usp... : PS2, Line 12: Alternatively inspect the file on the `web UI of our GitHub mirror https://github.com/flashrom/flashrom/blob/main/flashchips.c`_.
I would suggest moving this paragraph to the first one, because they're logically related
Done
https://review.coreboot.org/c/flashrom/+/82197/comment/09fba9c5_1f8a2639?usp... : PS2, Line 14: If you want to check whether a flash chip is supported in the given release, you can rebase your local : repo at the release tag, alternatively select a tag/branch in GitHub web UI (dropdown on the top-left).
It doesn't sound like a really user-friendly method to check whether a desired flash chip is support […]
I don't want to have *another* list of supported chips, I think there should be one canonical list in flashchips.c and then we can avoid duplication also not need to synchronize.
But! I was thinking maybe we can have a clever code/script which loops through flashchips.c and generates .rst file. And then sphinx would generate html file from it as a part of building docs. This would be cool, but I haven't looked into details how to do this :)
I also don't think this version is final , I just wanted to start the page. It's easier to update the page which exists (and perhaps other people will help).
Even after print_wiki.c deleted (which I plan to do only after the release), there will still be still print.c which is doing basically the same just without html tags!
Also yes, please add to the agenda any time :)
Let me know what do you think whether this patch can go ahead.
https://review.coreboot.org/c/flashrom/+/82197/comment/b180fc9f_d1f6378d?usp... : PS2, Line 23: Instructions how to update tested status of the chip are here: :doc:`/contrib_howtos/how_to_mark_chip_tested`. : : Instructions how to add support for a chip are here: :doc:`/contrib_howtos/how_to_add_new_chip`.
How about just adding them as a "related topics" list?
Done
-
Anastasia Klimchuk (Code Review)