Attention is currently required from: Nico Huber, Michał Żygowski, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 )
Change subject: acpi_ec: Implement basic ACPI embedded controller API
......................................................................
Patch Set 5:
(1 comment)
File acpi_ec.h:
https://review.coreboot.org/c/flashrom/+/55714/comment/3094be70_644acf69
PS4, Line 44: bool ec_write_cmd(uint8_t control_port, uint8_t cmd, unsigned int max_checks);
: bool ec_read_byte(uint8_t control_port, uint8_t data_port, uint8_t *data,
: unsigned int max_checks);
: bool ec_write_byte(uint8_t control_port, uint8_t data_port, uint8_t data,
: unsigned int max_checks);
:
Hmmm, let me ask this then: Was the `portpair` option of your driver […]
see this comment on why the ports are switched https://review.coreboot.org/c/flashrom/+/55715/comment/31f4833d_11f15376/#60...
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55714
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d
Gerrit-Change-Number: 55714
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 17:42:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment