Attention is currently required from: Felix Singer, Anastasia Klimchuk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67195 )
Change subject: tree/: Convert flashchip decode range func ptr to enum
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67195/comment/33e05b89_ba4b7115
PS8, Line 10: to
Duplicate "to"
Done
https://review.coreboot.org/c/flashrom/+/67195/comment/2e38582a_fb4ae673
PS8, Line 12: This follows from on from previous patches that
This sounds confusing
Done
https://review.coreboot.org/c/flashrom/+/67195/comment/b688d8ba_29d0a372
PS8, Line 16: b/242479049
You mean b:242479049 probably?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If6d08d414d3d1ddadc95ca1d407fc87c23ab543d
Gerrit-Change-Number: 67195
Gerrit-PatchSet: 10
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 10 Oct 2022 23:41:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment