Change in flashrom[master]: flashchips: add writeprotect bit layout map to chips - flashrom-gerrit

24 Dec 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58477 )
Change subject: flashchips: add writeprotect bit layout map to chips
......................................................................
Patch Set 22:
(2 comments)
File flash.h:
https://review.coreboot.org/c/flashrom/+/58477/comment/3226bb7c_aac9d49a 
PS21, Line 192: 0
...
Why give these numbers? Is there anything to sync with?
Done
https://review.coreboot.org/c/flashrom/+/58477/comment/f4d565bb_4371dc16 
PS21, Line 283: 	 */
...
We should generally try to find a better representation for the flash chips. […]
That's a good point, thanks.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id08d77e6d4ca5109c0d698271146d026dbc21284
Gerrit-Change-Number: 58477
Gerrit-PatchSet: 22
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Fri, 24 Dec 2021 06:48:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment