Change in flashrom[master]: ichspi: Split very long init function into two - flashrom-gerrit

15 Dec 2021


      Attention is currently required from:  Felix Singer, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58735 )
Change subject: ichspi: Split very long init function into two
......................................................................
Patch Set 1:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/58735/comment/75c61f97_73f963fb 
PS1, Line 2049:  else {
              : 		register_spi_master(&spi_master_ich9, NULL);
              : 	}
...
nit: Reverse the condition so that the simple case comes first
Not in this commit, please.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6789bc456a4878e6555831ae0b80ecbdbf62938b
Gerrit-Change-Number: 58735
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC:  Felix Singer felixsinger@posteo.net
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention:  Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 15:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To:  Felix Singer felixsinger@posteo.net
Gerrit-MessageType: comment