Attention is currently required from: Peter Marheine.
Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email )
Change subject: libflashrom: Added API to enumerate supported programmers ......................................................................
Patch Set 1:
(1 comment)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86921/comment/4a70547f_2179c3d8?usp... : PS1, Line 169: const char ** flashrom_supported_programmers(void);
I think this would be better avoiding any allocation, by exposing an iterator-like API. […]
I thought about this but flashrom already uses such approach in all flashrom_supported_* functions i.e. https://review.coreboot.org/c/flashrom/+/86921/1/libflashrom.c#161 I'm not sure how to implement it in flashrom_programmer_capabilities because it is temporary data https://review.coreboot.org/c/flashrom/+/86922 . please take a look
I will implement both
-
Dmitry Zhadinets (Code Review)