Attention is currently required from: Edward O'Callaghan.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72632 )
Change subject: jedec.c: Use JEDEC_ define from spi.h over magic ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: ``` jedec.c: In function 'probe_jedec_29gl': jedec.c:135:28: error: 'JEDEC_REMS' undeclared (first use in this function) 135 | chip_writeb(flash, JEDEC_REMS, bios + (0x5555 & mask)); | ^~~~~~~~~~ jedec.c:135:28: note: each undeclared identifier is reported only once for each function it appears in jedec.c: In function 'probe_jedec': jedec.c:219:28: error: 'JEDEC_REMS' undeclared (first use in this function) 219 | chip_writeb(flash, JEDEC_REMS, bios + ((shifted ? 0x2AAA : 0x5555) & mask)); | ^~~~~~~~~~ ```