[M] Change in flashrom[main]: flashchips: Remove Macronix MX25U25635F from chip list

Attention is currently required from: Anastasia Klimchuk, DZ, Stefan Reinauer. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79633?usp=email ) Change subject: flashchips: Remove Macronix MX25U25635F from chip list ...................................................................... Patch Set 1: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/79633/comment/4b20278f_2c9dc05b : PS1, Line 10310: .wps = {SECURITY, 7, OTP}, /* This bit is set by WPSEL command */
Thanks for details, now I understand the situation. […] Deleting the chip entry isn't a good solution as flashrom should still support the older model.
If it is possible for flashrom to distinguish the chips some how (e.g. custom opcode), then you can use a custom probe function to do that. Otherwise, if the customer builds their own version of flashrom, they can use a local blocklist to ignore certain chips with duplicated IDs. This is what we did for ChromeOS. -- To view, visit https://review.coreboot.org/c/flashrom/+/79633?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ief3fd7641bed817066692c4abffff6d3b0df16b9 Gerrit-Change-Number: 79633 Gerrit-PatchSet: 1 Gerrit-Owner: DZ Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: DZ Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Tue, 23 Jan 2024 23:34:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: DZ Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Nikolai Artemiev (Code Review)