Attention is currently required from: Anastasia Klimchuk, DZ, Stefan Reinauer.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79633?usp=email )
Change subject: flashchips: Remove Macronix MX25U25635F from chip list ......................................................................
Patch Set 1:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/79633/comment/4b20278f_2c9dc05b : PS1, Line 10310: .wps = {SECURITY, 7, OTP}, /* This bit is set by WPSEL command */
Thanks for details, now I understand the situation. […]
Deleting the chip entry isn't a good solution as flashrom should still support the older model.
If it is possible for flashrom to distinguish the chips some how (e.g. custom opcode), then you can use a custom probe function to do that.
Otherwise, if the customer builds their own version of flashrom, they can use a local blocklist to ignore certain chips with duplicated IDs. This is what we did for ChromeOS.
-
Nikolai Artemiev (Code Review)