Change in flashrom[master]: raiden_debug_spi: Move shutdown function above spi_master struct - flashrom-gerrit

27 Sep 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57974 )
Change subject: raiden_debug_spi: Move shutdown function above spi_master struct
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
One thing that I don't understand: why this change results in binary diffs? I was looking into this some time ago, and comparing objdump -d gives a difference in one mov instruction in raiden_debug_spi_shutdown section.
I will look once again, why the diff is produced. Leaving the comment unresolved.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/57974
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I567e24c9d39e24a4a1634ddcbdd05930760afcdc
Gerrit-Change-Number: 57974
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Mon, 27 Sep 2021 10:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment