Attention is currently required from: ChrisEric1 CECL, Thomas Heijligen, Edward O'Callaghan.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB Controller flashing
......................................................................
Patch Set 19:
(2 comments)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/101f1f99_4fcc96a4
PS19, Line 72: unsigned int curreadcnt;
Delete, similar to what you did for curwritecnt before
https://review.coreboot.org/c/flashrom/+/72057/comment/a16670b1_8d7591ed
PS19, Line 91: curreadcnt = min(4, readcnt - j);
Change to `uint32_t unsigned int curreadcnt;`, similar to what you did for `curwritecnt` above
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 19
Gerrit-Owner: ChrisEric1 CECL
christopherericlentocha@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: ChrisEric1 CECL
christopherericlentocha@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Thu, 16 Feb 2023 14:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment