Change in flashrom[master]: libflashrom,writeprotect: add flashrom_wp_{read,write}_chip_config()
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: libflashrom,writeprotect: add flashrom_wp_{read,write}_chip_config() ......................................................................
Patch Set 20:
(3 comments)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/d455cae1_2e3e3d13 PS16, Line 113: }
Loop body is one line so braces around loop body are not needed. And same for the loop right below. […]
Done
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/807a1ee5_3cb38bc2 PS18, Line 159: int
unsigned ?
It's counting down, `i` needs to get to -1 for the exit condition to evaluate to true.
https://review.coreboot.org/c/flashrom/+/58479/comment/595c0839_f707ef94 PS18, Line 171: int
ditto
ditto.
-
Nikolai Artemiev (Code Review)