David Hendricks has posted comments on this change. ( https://review.coreboot.org/22021 )
Change subject: spi25: Enable direct 4BA read and write using feature bits ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/22021/1/spi25.c File spi25.c:
https://review.coreboot.org/#/c/22021/1/spi25.c@582 PS1, Line 582: JEDEC_BYTE_PROGRAM_4BA So this will use a native 4BA instruction whether or not you use the extended address register. Maybe I'm missing something?
https://review.coreboot.org/#/c/22021/1/spi25.c@592 PS1, Line 592: JEDEC_READ_4BA same comment as above