Change in flashrom[master]: raiden_debug: Rename with '_DEBUG_SPI' suffix

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48105 )

Change subject: raiden_debug: Rename with '_DEBUG_SPI' suffix
......................................................................

raiden_debug: Rename with '_DEBUG_SPI' suffix

Unfortantly raiden_debug was upstreamed with a misnaming
of the CONFIG_ make param that introduces unnecessary divergence.
Rename to 'CONFIG_RAIDEN_DEBUG_SPI' as-is downstream.

Change-Id: I07c03647c329286bb223e4dae4665704e508db2c
Signed-off-by: Edward O'Callaghan 
---
M Makefile
M flashrom.c
M meson.build
M programmer.h
4 files changed, 11 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/48105/1

diff --git a/Makefile b/Makefile
index 0498624..327d43b 100644
--- a/Makefile
+++ b/Makefile
@@ -248,10 +248,10 @@
 else
 override CONFIG_RAYER_SPI = no
 endif
-ifeq ($(CONFIG_RAIDEN), yes)
-UNSUPPORTED_FEATURES += CONFIG_RAIDEN=yes
+ifeq ($(CONFIG_RAIDEN_DEBUG_SPI), yes)
+UNSUPPORTED_FEATURES += CONFIG_RAIDEN_DEBUG_SPI=yes
 else
-override CONFIG_RAIDEN = no
+override CONFIG_RAIDEN_DEBUG_SPI = no
 endif
 ifeq ($(CONFIG_NIC3COM), yes)
 UNSUPPORTED_FEATURES += CONFIG_NIC3COM=yes
@@ -691,7 +691,7 @@
 CONFIG_RAYER_SPI ?= yes

# ChromiumOS servo DUT debug board hardware support
-CONFIG_RAIDEN ?= yes
+CONFIG_RAIDEN_DEBUG_SPI ?= yes

# PonyProg2000 SPI hardware support
 CONFIG_PONY_SPI ?= yes
@@ -820,7 +820,7 @@
 override CONFIG_DIGILENT_SPI = no
 override CONFIG_DEVELOPERBOX_SPI = no
 override CONFIG_PICKIT2_SPI = no
-override CONFIG_RAIDEN = no
+override CONFIG_RAIDEN_DEBUG_SPI = no
 override CONFIG_STLINKV3_SPI = no
 endif
 ifeq ($(CONFIG_ENABLE_LIBPCI_PROGRAMMERS), no)
@@ -932,8 +932,8 @@
 NEED_RAW_ACCESS += CONFIG_RAYER_SPI
 endif

-ifeq ($(CONFIG_RAIDEN), yes)
-FEATURE_CFLAGS += -D'CONFIG_RAIDEN=1'
+ifeq ($(CONFIG_RAIDEN_DEBUG_SPI), yes)
+FEATURE_CFLAGS += -D'CONFIG_RAIDEN_DEBUG_SPI=1'
 PROGRAMMER_OBJS += raiden_debug_spi.o
 endif

diff --git a/flashrom.c b/flashrom.c
index 26e2df8..630e7ea 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -145,7 +145,7 @@
    },
 #endif

-#if CONFIG_RAIDEN == 1
+#if CONFIG_RAIDEN_DEBUG_SPI == 1
    {
    	.name			= "raiden_debug",
    	.type			= USB,
diff --git a/meson.build b/meson.build
index 8418d72..1acbdb3 100644
--- a/meson.build
+++ b/meson.build
@@ -179,7 +179,7 @@
 endif
 if config_raiden
   srcs += 'raiden_debug_spi.c'
-  cargs += '-DCONFIG_RAIDEN=1'
+  cargs += '-DCONFIG_RAIDEN_DEBUG_SPI=1'
 endif
 if config_internal
   srcs += 'board_enable.c'
diff --git a/programmer.h b/programmer.h
index ed30d89..c93bf83 100644
--- a/programmer.h
+++ b/programmer.h
@@ -46,7 +46,7 @@
 #if CONFIG_GFXNVIDIA == 1
    PROGRAMMER_GFXNVIDIA,
 #endif
-#if CONFIG_RAIDEN == 1
+#if CONFIG_RAIDEN_DEBUG_SPI == 1
    PROGRAMMER_RAIDEN,
 #endif
 #if CONFIG_DRKAISER == 1
@@ -417,7 +417,7 @@
 #endif

/* raiden_debug_spi.c */
-#if CONFIG_RAIDEN == 1
+#if CONFIG_RAIDEN_DEBUG_SPI == 1
 int raiden_debug_spi_init(void);
 extern const struct dev_entry devs_raiden[];
 #endif

[Sam McNally (Code Review)]

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48105 )

Change subject: raiden_debug: Rename with '_DEBUG_SPI' suffix
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/flashrom/+/48105/1/programmer.h 
File programmer.h:

https://review.coreboot.org/c/flashrom/+/48105/1/programmer.h@50 
PS1, Line 50: PROGRAMMER_RAIDEN
This needs updating too, probably in the other CL.

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48105 )

Change subject: raiden_debug: Rename with '_DEBUG_SPI' suffix
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/48105/1/programmer.h 
File programmer.h:

https://review.coreboot.org/c/flashrom/+/48105/1/programmer.h@50 
PS1, Line 50: PROGRAMMER_RAIDEN
> This needs updating too, probably in the other CL.

Ack

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48105 )

Change subject: raiden_debug: Rename with '_DEBUG_SPI' suffix
......................................................................

raiden_debug: Rename with '_DEBUG_SPI' suffix

Unfortantly raiden_debug was upstreamed with a misnaming
of the CONFIG_ make param that introduces unnecessary divergence.
Rename to 'CONFIG_RAIDEN_DEBUG_SPI' as-is downstream.

Change-Id: I07c03647c329286bb223e4dae4665704e508db2c
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/48105
Tested-by: build bot (Jenkins) 
Reviewed-by: Sam McNally 
---
M Makefile
M flashrom.c
M meson.build
M programmer.h
4 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Sam McNally: Looks good to me, approved

diff --git a/Makefile b/Makefile
index 0498624..327d43b 100644
--- a/Makefile
+++ b/Makefile
@@ -248,10 +248,10 @@
 else
 override CONFIG_RAYER_SPI = no
 endif
-ifeq ($(CONFIG_RAIDEN), yes)
-UNSUPPORTED_FEATURES += CONFIG_RAIDEN=yes
+ifeq ($(CONFIG_RAIDEN_DEBUG_SPI), yes)
+UNSUPPORTED_FEATURES += CONFIG_RAIDEN_DEBUG_SPI=yes
 else
-override CONFIG_RAIDEN = no
+override CONFIG_RAIDEN_DEBUG_SPI = no
 endif
 ifeq ($(CONFIG_NIC3COM), yes)
 UNSUPPORTED_FEATURES += CONFIG_NIC3COM=yes
@@ -691,7 +691,7 @@
 CONFIG_RAYER_SPI ?= yes

# ChromiumOS servo DUT debug board hardware support
-CONFIG_RAIDEN ?= yes
+CONFIG_RAIDEN_DEBUG_SPI ?= yes

# PonyProg2000 SPI hardware support
 CONFIG_PONY_SPI ?= yes
@@ -820,7 +820,7 @@
 override CONFIG_DIGILENT_SPI = no
 override CONFIG_DEVELOPERBOX_SPI = no
 override CONFIG_PICKIT2_SPI = no
-override CONFIG_RAIDEN = no
+override CONFIG_RAIDEN_DEBUG_SPI = no
 override CONFIG_STLINKV3_SPI = no
 endif
 ifeq ($(CONFIG_ENABLE_LIBPCI_PROGRAMMERS), no)
@@ -932,8 +932,8 @@
 NEED_RAW_ACCESS += CONFIG_RAYER_SPI
 endif

-ifeq ($(CONFIG_RAIDEN), yes)
-FEATURE_CFLAGS += -D'CONFIG_RAIDEN=1'
+ifeq ($(CONFIG_RAIDEN_DEBUG_SPI), yes)
+FEATURE_CFLAGS += -D'CONFIG_RAIDEN_DEBUG_SPI=1'
 PROGRAMMER_OBJS += raiden_debug_spi.o
 endif

diff --git a/flashrom.c b/flashrom.c
index 26e2df8..630e7ea 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -145,7 +145,7 @@
    },
 #endif

-#if CONFIG_RAIDEN == 1
+#if CONFIG_RAIDEN_DEBUG_SPI == 1
    {
    	.name			= "raiden_debug",
    	.type			= USB,
diff --git a/meson.build b/meson.build
index 8418d72..1acbdb3 100644
--- a/meson.build
+++ b/meson.build
@@ -179,7 +179,7 @@
 endif
 if config_raiden
   srcs += 'raiden_debug_spi.c'
-  cargs += '-DCONFIG_RAIDEN=1'
+  cargs += '-DCONFIG_RAIDEN_DEBUG_SPI=1'
 endif
 if config_internal
   srcs += 'board_enable.c'
diff --git a/programmer.h b/programmer.h
index ed30d89..c93bf83 100644
--- a/programmer.h
+++ b/programmer.h
@@ -46,7 +46,7 @@
 #if CONFIG_GFXNVIDIA == 1
    PROGRAMMER_GFXNVIDIA,
 #endif
-#if CONFIG_RAIDEN == 1
+#if CONFIG_RAIDEN_DEBUG_SPI == 1
    PROGRAMMER_RAIDEN,
 #endif
 #if CONFIG_DRKAISER == 1
@@ -417,7 +417,7 @@
 #endif

/* raiden_debug_spi.c */
-#if CONFIG_RAIDEN == 1
+#if CONFIG_RAIDEN_DEBUG_SPI == 1
 int raiden_debug_spi_init(void);
 extern const struct dev_entry devs_raiden[];
 #endif

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48105 )

Change subject: raiden_debug: Rename with '_DEBUG_SPI' suffix
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/flashrom/+/48105/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/48105/2//COMMIT_MSG@9 
PS2, Line 9: Unfortantly
Unfortunately