Attention is currently required from: David Wu, Edward O'Callaghan, Evan Benn, Hsuan Ting Chen.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79304?usp=email )
Change subject: flashrom_tester: Fix partial_lock_test on libflashrom ......................................................................
Patch Set 3:
(2 comments)
File util/flashrom_tester/flashrom/src/flashromlib.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/51359454_48fb908f : PS1, Line 200: .flag_set(FlashromFlag::FlashromFlagSkipUnreadableRegions, true);
These two are to handle the case of the CSME locking parts of flash. […]
IIUC we have to set all the values in Default? So I set them as false (boolean deafult value, also align with what classic_cli works
File util/flashrom_tester/flashrom/src/flashromlib.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/57cac227_442f2760 : PS2, Line 185: fn set_default_flags(&self) -> () { : self.flashrom : .borrow_mut() : .flag_set(FlashromFlag::FlashromFlagForce, false); : self.flashrom : .borrow_mut() : .flag_set(FlashromFlag::FlashromFlagForceBoardmismatch, false); : self.flashrom : .borrow_mut() : .flag_set(FlashromFlag::FlashromFlagVerifyAfterWrite, true); : self.flashrom : .borrow_mut() : .flag_set(FlashromFlag::FlashromFlagVerifyWholeChip, true); : }
You probably mean to be using the `Default` trait for the `FlashromFlag` type? Since `enum`'s are un […]
Done
Create another struct FlashromFlags and set its Default function.