Change in flashrom[master]: tree: Remove forward-declarations of structs for spi masters - flashrom-gerrit

29 Mar 2021


      Attention is currently required from: Nico Huber, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51731 )
Change subject: tree: Remove forward-declarations of structs for spi masters
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
...
A good test for such changes is if it results in the […]
+1 to Nico's suggestion, that is precisely how we check these things. If already done, just set the TEST= line to indicate a before,after objdump compare was performed to verify no change.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I256bd7c763efc010fc1f29f7c5853f150ac10739
Gerrit-Change-Number: 51731
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 29 Mar 2021 13:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment