Change in flashrom[master]: Makeile: reenable internal programmer for mipsel - flashrom-gerrit

23 Jan 2022


      Attention is currently required from: Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel
......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/df6055da_360b8bcb 
PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
I think this is overly strict, because the internal programmer will delegate to MTD if enabled, which is supported on more than just x86 and mipsel. For Chromium we use that delegation on ARM, for instance.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/61300
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Sun, 23 Jan 2022 22:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment