Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68438 )
Change subject: flashrom.c: Move count_max_decode_exceeding() to cli
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
It crossed my mind however I didn't want to introduce it to a user facing API pre-maturely. […]
Yeah, we can introduce new APIs when someone needs them.
Also, +1 to the idea of extracting the chunk of code using `limitexceeded` in `main()`.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68438
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If050eab7db8560676c03d5005a2b391313a0d642
Gerrit-Change-Number: 68438
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Thu, 20 Oct 2022 08:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment