Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57437 )
Change subject: tests: Revise mock chip definition and usage ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57437/comment/c1900fdb_96d8f5ba PS4, Line 24: fresh copy on the stack.
This made me chuckle a little :) What I always tell people when […]
Nico I appreciate your reviews so much! I know it's a big effort to review, it takes time and energy. And I produce heaps of stuff for review. Thank you!
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/57437/comment/e013f650_a312f468 PS3, Line 128: static struct flashchip chip_8MiB = {
Looks good. […]
Good to know! I just wasn't sure. wp is write-protect, I think. yes I think I can ignore it for now.
-
Anastasia Klimchuk (Code Review)