Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83242?usp=email )
Change subject: flashchips: Add Support for XMC XM25QH512C/XM25QH512D ......................................................................
Patch Set 2:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83242/comment/9343530b_933ac4aa?usp... : PS2, Line 22442: 64*1024 Please add spaces around `*`: `64 * 1024`
This comes from our code style: https://flashrom.org/dev_guide/development_guide.html#coding-style (which mostly follows Linux kernel style).
https://review.coreboot.org/c/flashrom/+/83242/comment/c6537cab_2f046540?usp... : PS2, Line 22458: .eraseblocks = { {4 * 1024, 16384} }, This line needs to be intended like the others
-
Anastasia Klimchuk (Code Review)