David Hendricks has posted comments on this change. ( https://review.coreboot.org/25706 )
Change subject: linux_mtd: Initial import
......................................................................
Patch Set 8: Verified+1
(1 comment)
I looked into using fileno() as you had suggested and as it turns out it works pretty easily. For some reason I was thinking I'd need additional error handling, but it "should not fail" (according to the manpage). So with that assumption it fits in quite easily.
https://review.coreboot.org/#/c/25706/7/linux_mtd.c
File linux_mtd.c:
https://review.coreboot.org/#/c/25706/7/linux_mtd.c@347
PS7, Line 347: return ret;
Missing error message and `close(dev_fd);`.
Done
--
To view, visit
https://review.coreboot.org/25706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599
Gerrit-Change-Number: 25706
Gerrit-PatchSet: 8
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Brian Norris
briannorris@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 May 2018 15:56:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes