Change in flashrom[master]: flashchips.c: EN29F002(A)(N)B tested +EW

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

Alan Green (Code Review)

26 Aug 2019 26 Aug '19

7:04 a.m.

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35092 )

Change subject: flashchips.c: EN29F002(A)(N)B tested +EW ......................................................................

flashchips.c: EN29F002(A)(N)B tested +EW

Mark EN29F002(A)(N)B as tested for erase and write. This chip was marked tested in the Chromium (downstream) repo change 98d917cfba55b68516cdf64c754d2f36c8c26722 "Add a bunch of new/tested stuff and various small changes 8"

TEST=Build and run flashrom -L

Signed-off-by: Alan Green avg@google.com Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/35092/1

diff --git a/flashchips.c b/flashchips.c index f84f1cc..3994c93 100644 --- a/flashchips.c +++ b/flashchips.c @@ -5398,7 +5398,7 @@ .total_size = 256, .page_size = 256, .feature_bits = FEATURE_ADDR_AAA | FEATURE_EITHER_RESET, - .tested = TEST_OK_PR, + .tested = TEST_OK_PREW, .probe = probe_jedec, .probe_timing = TIMING_ZERO, /* Datasheet has no timing info specified */ .block_erasers =

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Alan Green (Code Review)

26 Aug 26 Aug

7:06 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/35092

to look at the new patch set (#2).

Change subject: flashchips.c: EN29F002(A)(N)B tested +EW ......................................................................

flashchips.c: EN29F002(A)(N)B tested +EW

TEST=Build and run flashrom -L

Signed-off-by: Alan Green avg@google.com Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/35092/2

Angel Pons (Code Review)

2 Sep 2 Sep

1:11 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35092 )

Change subject: flashchips.c: EN29F002(A)(N)B tested +EW ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/flashrom/+/35092/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/35092/2//COMMIT_MSG@7 PS2, Line 7: flashchips.c: EN29F002(A)(N)B tested +EW Please make it a statement:

flashchips.c: Mark EN29F002(A)(N)B as tested +EW

-- To view, visit https://review.coreboot.org/c/flashrom/+/35092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 Gerrit-Change-Number: 35092 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 01 Sep 2019 23:11:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

17 Sep 17 Sep

9:41 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35092 )

Change subject: flashchips.c: EN29F002(A)(N)B tested +EW ......................................................................

Patch Set 2:

...

Patch Set 2: Code-Review+2

(1 comment)

I pinged Alan on this and he will fix it up soon. Thanks for taking the time to review these!

-- To view, visit https://review.coreboot.org/c/flashrom/+/35092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 Gerrit-Change-Number: 35092 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Sep 2019 07:41:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Alan Green (Code Review)

18 Sep 18 Sep

3:19 a.m.

New subject: Change in flashrom[master]: flashchips.c: Mark EN29F002(A)(N)B as tested +EW

Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/35092

to look at the new patch set (#3).

Change subject: flashchips.c: Mark EN29F002(A)(N)B as tested +EW ......................................................................

flashchips.c: Mark EN29F002(A)(N)B as tested +EW

TEST=Build and run flashrom -L

Signed-off-by: Alan Green avg@google.com Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/92/35092/3

-- To view, visit https://review.coreboot.org/c/flashrom/+/35092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 Gerrit-Change-Number: 35092 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

3:20 a.m.

New subject: Change in flashrom[master]: flashchips.c: Mark EN29F002(A)(N)B as tested +EW

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35092 )

Change subject: flashchips.c: Mark EN29F002(A)(N)B as tested +EW ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/35092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 Gerrit-Change-Number: 35092 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 18 Sep 2019 01:20:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

3:20 a.m.

New subject: Change in flashrom[master]: flashchips.c: Mark EN29F002(A)(N)B as tested +EW

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35092 )

Change subject: flashchips.c: Mark EN29F002(A)(N)B as tested +EW ......................................................................

flashchips.c: Mark EN29F002(A)(N)B as tested +EW

TEST=Build and run flashrom -L

Signed-off-by: Alan Green avg@google.com Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 Reviewed-on: https://review.coreboot.org/c/flashrom/+/35092 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/flashrom/+/35092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 Gerrit-Change-Number: 35092 Gerrit-PatchSet: 4 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

Alan Green (Code Review)

3:20 a.m.

New subject: Change in flashrom[master]: flashchips.c: Mark EN29F002(A)(N)B as tested +EW

Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35092 )

Change subject: flashchips.c: Mark EN29F002(A)(N)B as tested +EW ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/flashrom/+/35092/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/35092/2//COMMIT_MSG@7 PS2, Line 7: flashchips.c: EN29F002(A)(N)B tested +EW

...

Please make it a statement: […]

Done. Apologies for the very slow response.

-- To view, visit https://review.coreboot.org/c/flashrom/+/35092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idd26187905f389fc858eea5b13915af88e40afe9 Gerrit-Change-Number: 35092 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 18 Sep 2019 01:20:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

1922

days inactive

1945

days old

flashrom-gerrit@flashrom.org

7 comments

3 participants

tags (0)

participants (3)

Alan Green (Code Review)
Angel Pons (Code Review)
Edward O'Callaghan (Code Review)