Attention is currently required from: Kyösti Mälkki, Patrick Georgi, Patrick Rudolph.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78186?usp=email )
Change subject: ichspi: Add support for C740 PCH
......................................................................
Patch Set 3:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/78186/comment/44aa9632_5c8110fb :
PS1, Line 1032: if (content->ISL == 0x50)
That's 80 in decimal and is hit with <= 80 above?
That line wasn't present when I written the patch against v1.2.
Used latest main for testing and fixed a couple of placed where C620 was being used on C740.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/78186?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I80eebc0fcc14de9df823aceaee77870ad136f94a
Gerrit-Change-Number: 78186
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Comment-Date: Thu, 12 Oct 2023 14:15:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment